[webkit-reviews] review granted: [Bug 116729] [Windows] Expose database storage and cache locations via preferences : [Attachment 202867] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 116729: [Windows] Expose database storage and cache locations via
preferences
https://bugs.webkit.org/show_bug.cgi?id=116729

Attachment 202867: Patch
https://bugs.webkit.org/attachment.cgi?id=202867&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=202867&action=review


Seems reasonable.

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:209
> +    DWORD size = ::GetEnvironmentVariable(dumpRenderTreeTemp, 0, 0);
> +    Vector<TCHAR> buffer(size);
> +    if (::GetEnvironmentVariable(dumpRenderTreeTemp, buffer.data(),
buffer.size())) {
> +	   wstring path = buffer.data();
> +	   if (!path.empty() && (path[path.length() - 1] != L'\\'))
> +	       path.append(L"\\");
> +	   return WTF::String (path.data(), path.length());
> +    }
> +
> +    return WebCore::localUserSpecificStorageDirectory();

Do you really need all these explicit namespaces? This looks unusual.