[webkit-reviews] review denied: [Bug 116108] Improve -webkit-text-underline-position memory usage : [Attachment 201972] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Lamarque V. Souza
<Lamarque.Souza at basyskom.com>'s request for review:
Bug 116108: Improve -webkit-text-underline-position memory usage
https://bugs.webkit.org/show_bug.cgi?id=116108

Attachment 201972: Patch
https://bugs.webkit.org/attachment.cgi?id=201972&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201972&action=review


The patch looks like a good idea but I have concerns about constness.

Either those functions are badly named, or they should be const.

> Source/WebCore/rendering/RootInlineBox.cpp:345
> +float RootInlineBox::maxLogicalTop()
> +{
> +    float maxLogicalTop = 0;
> +    computeMaxLogicalTop(maxLogicalTop);
> +    return maxLogicalTop;
> +}
> +#endif // CSS3_TEXT

Looks like computeMaxLogicalTop() should be const. Then maxLogicalTop() should
be const too.