[webkit-reviews] review granted: [Bug 75790] PDFPlugins don't load when plugins are disabled, but they should : [Attachment 200507] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 75790: PDFPlugins don't load when plugins are disabled, but they should
https://bugs.webkit.org/show_bug.cgi?id=75790

Attachment 200507: patch
https://bugs.webkit.org/attachment.cgi?id=200507&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=200507&action=review


> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:125
> +PluginModuleInfo PluginInfoStore::findPluginForMIMEType(const String&
mimeType, bool onlyApplicationPlugins) const

Couldn’t this take a AllowedPluginTypes enum instead of a boolean?

> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:145
> +PluginModuleInfo PluginInfoStore::findPluginForExtension(const String&
extension, String& mimeType, bool onlyApplicationPlugins) const

Ditto.

> Source/WebKit2/UIProcess/Plugins/PluginInfoStore.cpp:208
> +PluginModuleInfo PluginInfoStore::findPlugin(String& mimeType, const KURL&
url, bool onlyApplicationPlugins)

Ditto.