[webkit-reviews] review denied: [Bug 112426] [WK2] Add support for selectTrailingWhitespaceEnabled setting : [Attachment 195954] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Manuel Rego Casasnovas
<rego at igalia.com>'s request for review:
Bug 112426: [WK2] Add support for selectTrailingWhitespaceEnabled setting
https://bugs.webkit.org/show_bug.cgi?id=112426

Attachment 195954: Patch
https://bugs.webkit.org/attachment.cgi?id=195954&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195954&action=review


I am confused. How does added two preferences, but not use them anywhere, fixes
the tests?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3842
> +bool WebPage::isSelectTrailingWhitespaceEnabled()
> +{
> +    return m_page->settings()->selectTrailingWhitespaceEnabled();
> +}
> +
> +void WebPage::setSelectTrailingWhitespaceEnabled(bool enabled)
> +{
> +    m_page->settings()->setSelectTrailingWhitespaceEnabled(enabled);
> +}
> +

This code looks unused, am I missing something?