[webkit-reviews] review requested: [Bug 115281] WebKit tools cannot apply git patches for filenames containing spaces : [Attachment 201923] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 15 23:03:47 PDT 2013
Alexey Proskuryakov <ap at webkit.org> has asked for review:
Bug 115281: WebKit tools cannot apply git patches for filenames containing
spaces
https://bugs.webkit.org/show_bug.cgi?id=115281
Attachment 201923: proposed fix
https://bugs.webkit.org/attachment.cgi?id=201923&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't really know what I'm doing here (neither Perl nor the structure of
patches). Please review carefully.
I think that the trick here was that +++ and --- lines are really of this
format:
--- Source/WebKit2/Resources/PlugInSandboxProfiles/com.macromedia.Flash
Player.plugin.sb<TAB>(revision 149145)
When there are no spaces, a path alone suffices, but if there are spaces, at
least the tab is desired.
More information about the webkit-reviews
mailing list