[webkit-reviews] review denied: [Bug 115824] [BlackBerry] Don't set active or hover styles on touch start : [Attachment 201876] Patch with changelog

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied gmak at rim.com's request for
review:
Bug 115824: [BlackBerry] Don't set active or hover styles on touch start
https://bugs.webkit.org/show_bug.cgi?id=115824

Attachment 201876: Patch with changelog
https://bugs.webkit.org/attachment.cgi?id=201876&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201876&action=review


> Source/WebCore/ChangeLog:15
> +	   Reviewed Internally by Mike Fenton and Mike Lattanzio.
> +	   Setting active or hover styles on links can require a style
recalculation and a relayout which on some pages such as
> +	   http://en.wikipedia.org/wiki/Olympic_Games (desktop version) can
take over 300 ms and severly impact our scrolling reaction time.
> +	   This optimization still lets us use active styles if the element is
a form control (so that we can get depressed
> +	   button states) or if the element or its parent has a touch listener
(this aligns us with ios and android behaviour.)
> +
> +	   No new tests because it shouldn't change behaviour for anybody else.


I sounds more like you have a bad architecture. Why would layout influence the
scrolling, I thought you had a multiprocess WebKit on blackberry?

> Source/WebCore/page/efl/EventHandlerEfl.cpp:131
> +    notImplemented();

This is not a notImplemented.