[webkit-reviews] review granted: [Bug 116182] REGRESSION(r147004): Find on Page banner doesn't appear while Web Inspector is visible : [Attachment 201869] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 116182: REGRESSION(r147004): Find on Page banner doesn't appear while Web
Inspector is visible
https://bugs.webkit.org/show_bug.cgi?id=116182

Attachment 201869: Patch
https://bugs.webkit.org/attachment.cgi?id=201869&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201869&action=review


This looks a bit fragile but definitely not more than the previous code.

If the Y coordinate are inverted, this patch looks correct.

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:628
> +    CGFloat inspectedViewTop = NSMaxY(inspectedViewFrame);

I am confused, for me the Max Y would be the bottom of a view.

Is this because of OS X sick inverted coordinates?