[webkit-reviews] review denied: [Bug 115933] [WK2] CRASH: EXC_BAD_ACCESS crash in WKContextGetInfoForInstalledPlugIns when the dispatch block is destroyed : [Attachment 201422] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Remy Demarest <rdemarest at apple.com>'s
request for review:
Bug 115933: [WK2] CRASH: EXC_BAD_ACCESS crash in
WKContextGetInfoForInstalledPlugIns when the dispatch block is destroyed
https://bugs.webkit.org/show_bug.cgi?id=115933

Attachment 201422: Patch
https://bugs.webkit.org/attachment.cgi?id=201422&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201422&action=review


> Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm:132
> -	   block(toAPI(array.get()), 0);
> +	   block(toAPI(array.release().leakRef()), 0);

I think you will get what you want with release().get(); release().leakRef()
wrong.