[webkit-reviews] review granted: [Bug 115931] REGRESSION: Lines jump up and down while typing Chinese or Japanese : [Attachment 201442] Reverted erroneous test change
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri May 10 17:57:12 PDT 2013
Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 115931: REGRESSION: Lines jump up and down while typing Chinese or Japanese
https://bugs.webkit.org/show_bug.cgi?id=115931
Attachment 201442: Reverted erroneous test change
https://bugs.webkit.org/attachment.cgi?id=201442&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201442&action=review
> Source/WebCore/rendering/RenderBlockLineLayout.cpp:3094
> + if (wordMeasurement.fallbackFonts.isEmpty() &&
!fallbackFonts.isEmpty())
> + wordMeasurement.fallbackFonts.swap(fallbackFonts);
Sure could use a why comment.
More information about the webkit-reviews
mailing list