[webkit-reviews] review granted: [Bug 111974] Text flow broken in elements with vertical align top/bottom and inline elements taller than line-height : [Attachment 201280] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 111974: Text flow broken in elements with vertical align top/bottom and
inline elements taller than line-height
https://bugs.webkit.org/show_bug.cgi?id=111974

Attachment 201280: Patch
https://bugs.webkit.org/attachment.cgi?id=201280&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201280&action=review


> Source/WebCore/rendering/InlineFlowBox.cpp:485
> +    // The vertical-align property only applies to inline elements and table
cells.

Instead of repeating the code, refer to
http://www.w3.org/TR/2011/REC-CSS2-20110607/visudet.html#line-height.

Should we also check this condition in RenderStyle::diff (for optimization)?