[webkit-reviews] review requested: [Bug 115917] svg/as-image/img-zoom-svg-stylesheet.html crashes with NetworkProcess enabled : [Attachment 201362] Patch v1

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 115917: svg/as-image/img-zoom-svg-stylesheet.html crashes with
NetworkProcess enabled
https://bugs.webkit.org/show_bug.cgi?id=115917

Attachment 201362: Patch v1
https://bugs.webkit.org/attachment.cgi?id=201362&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
This patch is straight forward and makes things much safer in WK2.

I don't feel great about it - It is arguably a layering violation in
FrameLoaderClient.  But definitely less of one than "hasWebView" is, for
example.

That said, I can't think of a fix for this problem that:
A - Isn't much more hackey (exposing an "isEmptyFrameLoaderClient() method, for
example)
B - Doesn't require much more refactoring of Frame/FrameLoader/Page (pushing
ID's down in to WebCore)
C - Doesn't require much more refactoring of SVG-as-images (making them use the
normal WebFrame mechanism instead of directly creating their own WebCore::Frame