[webkit-reviews] review granted: [Bug 115816] new-run-webkit-websocketserver doesn't work after Chromium removal : [Attachment 201092] Fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 8 12:17:36 PDT 2013
Joseph Pecoraro <joepeck at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 115816: new-run-webkit-websocketserver doesn't work after Chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115816
Attachment 201092: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=201092&action=review
------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=201092&action=review
Looks good to me! Thanks.
> Tools/Scripts/new-run-webkit-websocketserver:38
> +from webkitpy.port import platform_options
Alphabetical order? Or does that style not matter in py.
> Tools/Scripts/new-run-webkit-websocketserver:106
> # FIXME: Make this work with other ports as well.
Seems like you can remove the FIXME now.
More information about the webkit-reviews
mailing list