[webkit-reviews] review granted: [Bug 115792] Coalesce WKView visibleRect changes : [Attachment 201091] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 115792: Coalesce WKView visibleRect changes
https://bugs.webkit.org/show_bug.cgi?id=115792

Attachment 201091: patch
https://bugs.webkit.org/attachment.cgi?id=201091&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=201091&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:637
> +    if (m_sendViewExposedRectChangedTimer.isActive())
> +	   m_sendViewExposedRectChangedTimer.stop();

Can't you unconditionally call stop?

> Source/WebKit2/UIProcess/WebPageProxy.h:1272
> +    WebCore::Timer<WebPageProxy> m_sendViewExposedRectChangedTimer;

Hard to parse this name. How about m_exposedRectChangedTimer?

> Source/WebKit2/UIProcess/WebPageProxy.h:1274
> +    WebCore::FloatRect m_lastSentViewExposedRect;

m_lastExposedRect?