[webkit-reviews] review requested: [Bug 75790] PDFPlugins don't load when plugins are disabled, but they should : [Attachment 200211] changelogs

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has asked  for review:
Bug 75790: PDFPlugins don't load when plugins are disabled, but they should
https://bugs.webkit.org/show_bug.cgi?id=75790

Attachment 200211: changelogs
https://bugs.webkit.org/attachment.cgi?id=200211&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
I still think it should be possible to do this better without complicating all
of the WebKit* side call sites, by making PluginData and the plugin cache
invalidate when the plugin pref is flipped, and then just depending on
PluginData not including any non-app-plug-ins if the pref is off. However, I'm
not sure that'll work since it looks like the FrameLoaderClient can override
allowPlugins for arbitrary reasons, not just the state of the setting... so I'm
not doing that for now. Let's see what others think.

Not sure I'm totally happy with stuff yet, but this could use a round of
scathing review.