[webkit-reviews] review granted: [Bug 114819] Show a block cursor in overtype mode : [Attachment 200207] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 114819: Show a block cursor in overtype mode
https://bugs.webkit.org/show_bug.cgi?id=114819

Attachment 200207: Patch
https://bugs.webkit.org/attachment.cgi?id=200207&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=200207&action=review


> LayoutTests/editing/selection/block-cursor-overtype-mode.html:36
> +    for (var i=0; i < textNode.length; i++) {

Space around =.

> LayoutTests/editing/selection/block-cursor-overtype-mode.html:43
> +	       if (expected[i-1] == ">")

Wrong indentation. 4 spaces.

> LayoutTests/editing/selection/block-cursor-overtype-mode.html:45
> +	    else

Tab

> LayoutTests/editing/selection/block-cursor-overtype-mode.html:47
> +	}

Tab

> LayoutTests/editing/selection/block-cursor-overtype-mode.html:50
> +	shouldBeTrue("blockCursor.width > 1");

Tab