[webkit-reviews] review denied: [Bug 113135] Accurately set Accept HTTP header for image requests : [Attachment 194708] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 30 11:37:47 PDT 2013


Adam Barth <abarth at webkit.org> has denied Christophe Dumez <dchris at gmail.com>'s
request for review:
Bug 113135: Accurately set Accept HTTP header for image requests
https://bugs.webkit.org/show_bug.cgi?id=113135

Attachment 194708: Patch
https://bugs.webkit.org/attachment.cgi?id=194708&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194708&action=review


> Source/WebCore/ChangeLog:10
> +	   Changed the Accept header for images to
"image/png,image/*;q=0.8,*/*;q=0.5"
> +	   to match Firefox. We were previously not setting the Accept header
for image
> +	   requests so the server had no way to know we expect an image.

I don't see why we would want to accept this patch.  It just bloats HTTP
requests without any tangible benefit.


More information about the webkit-reviews mailing list