[webkit-reviews] review denied: [Bug 113247] [v8] Binding integrity: add ScriptWrappable::init() and call it. : [Attachment 194955] Patch, add missing newline.

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Thomas Sepez <tsepez at chromium.org>'s
request for review:
Bug 113247: [v8] Binding integrity: add ScriptWrappable::init() and call it.
https://bugs.webkit.org/show_bug.cgi?id=113247

Attachment 194955: Patch, add missing newline.
https://bugs.webkit.org/attachment.cgi?id=194955&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194955&action=review


This patch does too much.  We should just add the call to init in the first
patch.

> Source/WebCore/bindings/v8/ScriptWrappable.h:138
> +    template <typename T>static void init(T* object) { }

In debug, we should set a bool on this object to ensure that init is always
called.