[webkit-reviews] review granted: [Bug 111790] Flexitems no longer default min-width to min-content : [Attachment 195807] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 29 15:35:01 PDT 2013
Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 111790: Flexitems no longer default min-width to min-content
https://bugs.webkit.org/show_bug.cgi?id=111790
Attachment 195807: Patch
https://bugs.webkit.org/attachment.cgi?id=195807&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195807&action=review
> Source/WebCore/rendering/RenderBox.cpp:2204
> + ASSERT(!logicalWidth.isUndefined());
This was true before this patch, right?
> LayoutTests/ChangeLog:14
> + * css3/flexbox/flex-item-min-size-expected.txt: Removed.
> + * css3/flexbox/flex-item-min-size.html: Removed.
> + These tests are now redundant with tests in
fast/css-intrinsic-dimensions.
Ok, although it would be nice to have more tests for flex items with a
min-width of -webkit-min-content.
More information about the webkit-reviews
mailing list