[webkit-reviews] review canceled: [Bug 113546] [CSS Grid Layout] Align our grid-line handling with the updated specification : [Attachment 195685] Proposed fix 1: Update our handling, our tests. Doesn't handle the start/before case as it could grow the grid.

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 113546: [CSS Grid Layout] Align our grid-line handling with the updated
specification
https://bugs.webkit.org/show_bug.cgi?id=113546

Attachment 195685: Proposed fix 1: Update our handling, our tests. Doesn't
handle the start/before case as it could grow the grid.
https://bugs.webkit.org/attachment.cgi?id=195685&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195685&action=review


>> Source/WebCore/rendering/RenderGrid.cpp:338
>> +	// See http://lists.w3.org/Archives/Public/www-style/2013Mar/0593.html
> 
> I don't think that's what the email is saying.  I think it's saying if there
are 3 grid columns and the position is -1, translate the position to 3, not 1.

Confirmed with Tab that you are totally right, I misread the answer. The
specification was updated yesterday so let me loop back on it for this patch.