[webkit-reviews] review denied: [Bug 113317] [GTK][AC] Use transform property of ClutterActor : [Attachment 195590] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 113317: [GTK][AC] Use transform property of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113317

Attachment 195590: Patch
https://bugs.webkit.org/attachment.cgi?id=195590&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195590&action=review


r- so we can get this bug reported in clutter, thanks for explaining the
problem, hopefully my suggested comment is easier to understand =)

>> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:618
>> +	//
https://developer.gnome.org/clutter/stable/ClutterActor.html#ClutterActor--tran
sform-set
> 
> I don't understand this very well. So if the actor already has a
transformation when the animation starts, the animation runs twice (as
described in the previous comment)? Setting the matrix to NULL does indeed set
transform-set to FALSE.

OK, so the problem is if there is an existing transform the animation does not
happen. I think we should replace this whole comment with that description:
"Work-around the fact that if there is a transform already set the animation
fails to start." This is a bug in clutter so I think we should report it in
bugzilla.gnome.org and add the bug URI to the comment as well.