[webkit-reviews] review granted: [Bug 113424] Prepare extend-selection-enclosing-block test to support different editing behavior : [Attachment 195357] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 28 11:29:17 PDT 2013
Ryosuke Niwa <rniwa at webkit.org> has granted Claudio Saavedra
<csaavedra at igalia.com>'s request for review:
Bug 113424: Prepare extend-selection-enclosing-block test to support different
editing behavior
https://bugs.webkit.org/show_bug.cgi?id=113424
Attachment 195357: Patch
https://bugs.webkit.org/attachment.cgi?id=195357&action=review
------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195357&action=review
> LayoutTests/editing/selection/resources/extend-selection.js:111
> + return extendAndLogSelection({'mac': extendSelectionWithinBlock
}[platform],
Nit: space before }.
> LayoutTests/editing/selection/resources/extend-selection.js:113
> }
Wrong indentation. direction should be exactly 4 specs to the right of return.
It seems like we can fit all of this in one line anyway.
More information about the webkit-reviews
mailing list