[webkit-reviews] review granted: [Bug 113374] DFG should use CheckStructure for typed array checks whenever possible : [Attachment 195248] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 113374: DFG should use CheckStructure for typed array checks whenever
possible
https://bugs.webkit.org/show_bug.cgi?id=113374

Attachment 195248: Patch
https://bugs.webkit.org/attachment.cgi?id=195248&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195248&action=review


r=me

Is this a speedup?

> Source/JavaScriptCore/dfg/DFGArrayMode.h:353
> +	       // It might benefit from structure checks! If it ends up not
benefiting, we can just
> +	       // remove it.

Would be nice to clarify that FixupPhase will remove it.