[webkit-reviews] review granted: [Bug 111894] Regression: Crash when selecting Hebrew and numbers in a list : [Attachment 195306] Patch

Wed Mar 27 09:17:45 PDT 2013

Ryosuke Niwa <rniwa at webkit.org> has granted Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 111894: Regression: Crash when selecting Hebrew and numbers in a list
https://bugs.webkit.org/show_bug.cgi?id=111894

Attachment 195306: Patch
https://bugs.webkit.org/attachment.cgi?id=195306&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195306&action=review

> LayoutTests/editing/selection/click-on-anonymous-content-crash.html:1
> +<html>

Missing DOCTYPE.

> LayoutTests/editing/selection/click-on-anonymous-content-crash.html:3
> +<script src="../../fast/js/resources/js-test-pre.js"></script>

Why do we need js-test-pre.js?

> LayoutTests/editing/selection/click-on-anonymous-content-crash.html:9
> +    if (window.internals) {

Please check window.eventSender instead. internals is never used in this test.