[webkit-reviews] review granted: [Bug 113381] Web Inspector: Breakpoint manager should restore breakpoints when uiSourceCode is added. : [Attachment 195286] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 113381: Web Inspector: Breakpoint manager should restore breakpoints when
uiSourceCode is added.
https://bugs.webkit.org/show_bug.cgi?id=113381

Attachment 195286: Patch
https://bugs.webkit.org/attachment.cgi?id=195286&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195286&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:133
> +	   var isIdentityChanged = /** @type {WebInspector.UISourceCode} */
(event.data.isIdentityChanged);

Poor cast.

> Source/WebCore/inspector/front-end/UISourceCode.js:670
> +	   data.isIdentityChanged = data.isIdentity !== wasIdentity;

identityHasChanged