[webkit-reviews] review denied: [Bug 113398] Web Inspector: dispatch inspectNode to frontend without injected script : [Attachment 195293] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 113398: Web Inspector: dispatch inspectNode to frontend without injected
script
https://bugs.webkit.org/show_bug.cgi?id=113398

Attachment 195293: Patch
https://bugs.webkit.org/attachment.cgi?id=195293&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195293&action=review


> Source/WebCore/inspector/Inspector.json:1992
> +		   "name": "shouldInspectNode",

You don't want them on DOM domain, you also want them to be hidden.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:1031
> +    int nodeId = pushNodePathToFrontend(m_nodeToFocus.get());

It might be too early to push the node - document might not be requested yet.