[webkit-reviews] review denied: [Bug 104207] Implement SVG2's buffered-rendering property : [Attachment 194942] Update per reviewer comments

[bugzilla-daemon at webkit.org]

Stephen Chenney <schenney at chromium.org> has denied Philip Rogers
<pdr at google.com>'s request for review:
Bug 104207: Implement SVG2's buffered-rendering property
https://bugs.webkit.org/show_bug.cgi?id=104207

Attachment 194942: Update per reviewer comments
https://bugs.webkit.org/attachment.cgi?id=194942&action=review

------- Additional Comments from Stephen Chenney <schenney at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194942&action=review


Looks like I missed an issue earlier. Another pass required.

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:339
> +	   if (bufferSize != imageBuffer->internalSize())

Below you use expandedIntSize(boundingBox.size()), but here you compute
something else to check the size against. This seems like a problem, as you'll
get a different image size depending on which code path you take.

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:345
> +	   if (imageBuffer =
m_paintInfo->context->createCompatibleBuffer(expandedIntSize(boundingBox.size()
), true)) {

Above you include scale information in computing the size.

> LayoutTests/ChangeLog:58
> +	   * platform/qt/css3/selectors3/xhtml/css3-modsel-14a7-expected.png:

This seems rather unexpected. Find/Replace error?