[webkit-reviews] review granted: [Bug 113211] Web Inspector: refactor code duplication: WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements : [Attachment 194932] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 113211: Web Inspector: refactor code duplication:
WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements
https://bugs.webkit.org/show_bug.cgi?id=113211

Attachment 194932: Patch
https://bugs.webkit.org/attachment.cgi?id=194932&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194932&action=review


> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:105
>	       for (var i = 0; i < this.extraProperties.length; ++i)

style: please add {} for multiline if block.

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:473
> +WebInspector.ObjectPropertyTreeElement.wrapPropertyAsElements =
function(treeElement, properties, internalProperties, constructor, comparator,
skipProto, value) {

wrapPropertyAsElements -> populateWithProperties
constructor -> treeElementConstructor