[webkit-reviews] review denied: [Bug 102349] :enabled should match with an anchor element having href attribute : [Attachment 174577] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 25 18:01:35 PDT 2013
Kent Tamura <tkent at chromium.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 102349: :enabled should match with an anchor element having href attribute
https://bugs.webkit.org/show_bug.cgi?id=102349
Attachment 174577: Patch
https://bugs.webkit.org/attachment.cgi?id=174577&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174577&action=review
> Source/WebCore/css/SelectorChecker.cpp:1046
> + if (element->hasTagName(aTag))
> + return element->isLink();
We shouldn't add hasTagName checks in CSS code any more, should have
Element::matchesEnabledPseudoClass virtual function instead.
More information about the webkit-reviews
mailing list