[webkit-reviews] review denied: [Bug 113220] Should close select popup when the element loses focus : [Attachment 194913] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 113220: Should close select popup when the element loses focus
https://bugs.webkit.org/show_bug.cgi?id=113220

Attachment 194913: Patch
https://bugs.webkit.org/attachment.cgi?id=194913&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194913&action=review


> Source/WebCore/html/HTMLSelectElement.cpp:1231
> +	   if (RenderMenuList* menuList = toRenderMenuList(renderer())) {

We need to check renderer()->isMenuList(). A blur event handler in capturing
phase can modify renderer state before the blur event reaches to the target
element.

> Source/WebCore/testing/Internals.cpp:2068
> +    HTMLSelectElement* select = toHTMLSelectElement(node);

Possible bad cast.  Please check element type even in testing code not to
disturb fuzzers.

> Source/WebCore/testing/Internals.cpp:2069
> +    RenderMenuList* menuList = toRenderMenuList(select->renderer());

ditto.

> LayoutTests/fast/forms/select-popup-closes-on-blur-expected.txt:3
> +PASS internals.isSelectPopupVisible(popup) is true
> +PASS internals.isSelectPopupVisible(popup) is false
> +Test for http://bugs.webkit.org/show_bug.cgi?id=113220 Ensures select popup
closes when focus changes.

Test description after test results is not good.  Please use description() to
show the description.