[webkit-reviews] review denied: [Bug 113080] Web Inspector: Flame Chart. Scroll dividers together with underlying chart. : [Attachment 194703] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 113080: Web Inspector: Flame Chart. Scroll dividers together with
underlying chart.
https://bugs.webkit.org/show_bug.cgi?id=113080

Attachment 194703: Patch
https://bugs.webkit.org/attachment.cgi?id=194703&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194703&action=review


> Source/WebCore/inspector/front-end/TimelineGrid.js:94
> +	   if (calculator.grandMinimumBoundary)

Checking for function existence is not compiler friendly.

> Source/WebCore/inspector/front-end/TimelineGrid.js:132
> +		   left =
calculator.computePosition(calculator.minimumBoundary() + slice * i -
sliceRemainder);

If you want dividers to be consistent with your canvas data, you should paint
them on canvas. updateDividers is an expensive method.