[webkit-reviews] review denied: [Bug 113138] Web Inspector: OverviewGrid. Dragged window may change its width due to accumulating rounding error : [Attachment 194709] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 113138: Web Inspector: OverviewGrid. Dragged window may change its width
due to accumulating rounding error
https://bugs.webkit.org/show_bug.cgi?id=113138

Attachment 194709: Patch
https://bugs.webkit.org/attachment.cgi?id=194709&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194709&action=review


> Source/WebCore/ChangeLog:8
> +	   The old version had problem with rounding because it recalculates
the window size on each event.

Why would this be a problem?

> Source/WebCore/inspector/front-end/OverviewGrid.js:320
> +	   var delta = (event.pageX - this._dragStartPoint) /
this._parentElement.clientWidth;

I am not sure we need more complexity in this code.