[webkit-reviews] review granted: [Bug 112965] Prefer 'KURL(ParsedURLString, String)' when dealing with known-good data. : [Attachment 194340] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Mike West
<mkwst at chromium.org>'s request for review:
Bug 112965: Prefer 'KURL(ParsedURLString, String)' when dealing with known-good
data.
https://bugs.webkit.org/show_bug.cgi?id=112965

Attachment 194340: Patch
https://bugs.webkit.org/attachment.cgi?id=194340&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194340&action=review


We still don't have a class that wraps a known good string without KURL size
overhead?

> Source/WebCore/page/SecurityOrigin.cpp:532
> +    return create(KURL(ParsedURLString, protocol + "://" + host + ":" +
String::number(port)));

This isn't normalized to append a slash? Please watch KURL based debug testers.


> Source/WebCore/page/SecurityOrigin.cpp:540
> +    return create(KURL(ParsedURLString, protocol + "://" + host + ":" +
String::number(port)));

Ditto.