[webkit-reviews] review denied: [Bug 112713] [chromium] Support Quota API in Worker in WebKit API : [Attachment 194414] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 112713: [chromium] Support Quota API in Worker in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=112713

Attachment 194414: Patch
https://bugs.webkit.org/attachment.cgi?id=194414&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=194414&action=review


Where are the tests?

Plus the other comment.

> Source/WebKit/chromium/src/WorkerStorageQuotaCallbacksBridge.cpp:91
> +// that it only gets deleted on the worker context thread which is verified
by ~Observer.

Kinuko's previous comment about this:
"Can we update this FIXME to:

// FIXME: Replace WebFrame parameter in queryStorageUsageAndQuota() with
WebString and move the method to Platform so that we can remove all these
complexity for Worker."