[webkit-reviews] review granted: [Bug 112957] JSC: op_debug bytecode charPosition to column computation is O(n^2) : [Attachment 194405] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 21 18:29:12 PDT 2013


Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 112957: JSC: op_debug bytecode charPosition to column computation is O(n^2)
https://bugs.webkit.org/show_bug.cgi?id=112957

Attachment 194405: the patch
https://bugs.webkit.org/attachment.cgi?id=194405&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I see -- this function returns the character after the line terminator. I think
"lineStart" is a fine name for that, and now I see why it needs different
logic.


More information about the webkit-reviews mailing list