[webkit-reviews] review granted: [Bug 112988] JSC profiler should have an at-a-glance report of the success of DFG optimization : [Attachment 194401] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 112988: JSC profiler should have an at-a-glance report of the success of
DFG optimization
https://bugs.webkit.org/show_bug.cgi?id=112988

Attachment 194401: the patch
https://bugs.webkit.org/attachment.cgi?id=194401&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=194401&action=review


What do we do with these numbers? Higher is better, but what we really want to
know is how many calls/gets/etc. did we fail to optimize, and we can only know
that with a number where lower is better, or if we display a total.

> Source/JavaScriptCore/profiler/ProfilerCompilation.h:61
> +    void noticeMiscInline() { m_numMiscInlines++; }

What's this for? It's unused. I just spent five minutes trying to figure out
why the "M" column was always zero. Why do you torture me?

> Tools/Scripts/display-profiler-output:537
> +	   print(" " + center("Recent Opts", recentOptsCols))

What does "Recent" mean here? Is it the last compilation? If so, can we call it
"Last Opts"?