[webkit-reviews] review granted: [Bug 111334] Web Inspector: Plumbing CSS warnings : [Attachment 193871] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 111334: Web Inspector: Plumbing CSS warnings
https://bugs.webkit.org/show_bug.cgi?id=111334

Attachment 193871: Patch
https://bugs.webkit.org/attachment.cgi?id=193871&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193871&action=review


> Source/WebCore/css/CSSParser.cpp:11219
> +    if (!isLoggingErrors())

Check for m_logErrors to speed things up.

>> Source/WebCore/page/PageConsole.cpp:173
>> +	    return;
> 
> Why not allow CSS messages to print to stdout too? I use this to ease
development of the Web Inspector, so I don't always need to inspect the
Inspector to see messages. Please remove this unless there is a compelling
reason.

It would need a ton of rebaselines. We'll do that when the dust settles.