[webkit-reviews] review denied: [Bug 112689] Web Inspector: factor out node search controller from inspector.js : [Attachment 193860] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 112689: Web Inspector: factor out node search controller from inspector.js
https://bugs.webkit.org/show_bug.cgi?id=112689

Attachment 193860: Patch
https://bugs.webkit.org/attachment.cgi?id=193860&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193860&action=review


> Source/WebCore/WebCore.vcproj/WebCore.vcproj:77701
> +				       
RelativePath="..\inspector\front-end\ElementInspectionController.js"

InspectElementModeController?

> Source/WebCore/inspector/front-end/ElementInspectionController.js:34
> +    this.toggleSearchButton = new
WebInspector.StatusBarButton(WebInspector.UIString("Select an element in the
page to inspect it."), "node-search-status-bar-item");

Lets hide it.

> Source/WebCore/inspector/front-end/inspector.js:97
> +	      
mainStatusBar.insertBefore(this.elementInspectionController.toggleSearchButton.
element, bottomStatusBarContainer);

You should encapsulate (hide) toggleSearchButton.

> Source/WebCore/inspector/front-end/inspector.js:677
> +    section.addKey(elementInspectionShortcut, WebInspector.UIString("Select
node to inspect"));

Why is "Select node to inspect" string here?

> Source/WebCore/inspector/front-end/inspector.js:969
> +    if (WebInspector.elementInspectionController &&
WebInspector.elementInspectionController.enabled()) {

Can it be missing?