[webkit-reviews] review denied: [Bug 112126] Implement overtype mode for editable content : [Attachment 193862] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 112126: Implement overtype mode for editable content
https://bugs.webkit.org/show_bug.cgi?id=112126

Attachment 193862: Patch
https://bugs.webkit.org/attachment.cgi?id=193862&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193862&action=review


>> Source/WebCore/editing/InsertTextCommand.cpp:120
>> +	replaceTextInNodePreservingMarkers(textNode,
start.offsetInContainerNode(), count, text);
> 
> Why are we preserving markers? That doesn't make much sense. e.g. all
spellchecking markers, etc… will remain there.

r- because of this.