[webkit-reviews] review granted: [Bug 112731] Changes to VS2010 project files should only trigger builds on Windows bots. : [Attachment 193904] patch v2

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 112731: Changes to VS2010 project files should only trigger builds on
Windows bots.
https://bugs.webkit.org/show_bug.cgi?id=112731

Attachment 193904: patch v2
https://bugs.webkit.org/attachment.cgi?id=193904&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193904&action=review


> BuildSlaveSupport/build.webkit.org-config/wkbuild.py:97
> +	   (r"\.(?:vcproj|vsprops|sln|vcxproj|props|filters)$", ["win"]),

Assuming these extensions are actually unique to your platform.

> BuildSlaveSupport/build.webkit.org-config/wkbuild.py:102
> +	   (r"\.(?:vcproj/|vcxproj/)", ["win"]),

You could put the slash outside of the or :P