[webkit-reviews] review denied: [Bug 111578] Web Inspector: split Console into two entities, a web-facing bound object and page console. : [Attachment 193743] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied  review:
Bug 111578: Web Inspector: split Console into two entities, a web-facing bound
object and page console.
https://bugs.webkit.org/show_bug.cgi?id=111578

Attachment 193743: Patch
https://bugs.webkit.org/attachment.cgi?id=193743&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193743&action=review


> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13641
>  \ No newline at end of file

I am not sure if newline is expected here. Please revert this change.

> Source/WebCore/dom/Document.cpp:4847
> +    if (page())

if (Page* page = page())
    page->console()->addMessage(source, level, message, requestIdentifier,
this);

> Source/WebCore/dom/Document.cpp:4858
> +    if (page())

Ditto

> Source/WebCore/xml/XSLStyleSheetLibxslt.cpp:27
>  #include "DOMWindow.h"

I still think you don't need to include DOMWindow.h here.

> Source/WebCore/xml/XSLTProcessorLibxslt.cpp:30
>  #include "DOMWindow.h"

Ditto