[webkit-reviews] review granted: [Bug 112066] Inspector: IndexedDB clear button and menu item : [Attachment 193682] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 112066: Inspector: IndexedDB clear button and menu item
https://bugs.webkit.org/show_bug.cgi?id=112066

Attachment 193682: Patch
https://bugs.webkit.org/attachment.cgi?id=193682&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193682&action=review


Please rebaseline and fix nits before landing.

> Source/WebCore/ChangeLog:27
> +2013-03-11  Alec Flett  <alecflett at chromium.org>

Please rebaseline

> Source/WebCore/inspector/Inspector.json:1416
> +		       { "name":  "securityOrigin", "type": "string",
"description": "Security origin." },

extra space after "name":

> Source/WebCore/inspector/front-end/IndexedDBViews.js:130
> +    this._clearButton = new
WebInspector.StatusBarButton(WebInspector.UIString("Clear All Data"),
"clear-storage-status-bar-item");

"Clear object store" and you will need to add it to
Source/WebCore/English.lproj/localizedStrings.js.
Or just make it "Clear".