[webkit-reviews] review granted: [Bug 112584] Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid : [Attachment 193590] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 112584: Web Inspector: move _timelineGrid && _timelineOverviewWindow from
TimelineOverviewPane into a new class OverviewGrid
https://bugs.webkit.org/show_bug.cgi?id=112584

Attachment 193590: Patch
https://bugs.webkit.org/attachment.cgi?id=193590&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193590&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:-98
> -   
this._overviewGrid.itemsGraphsElement.appendChild(this._categoryStrips.element)
;

appendAfter...

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:120
> +    itemsGraphsElement: function()

Hide this one.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:162
> +    addEventDividers: function(dividers)

Is this used?