[webkit-reviews] review canceled: [Bug 112457] Determine background visibility at layout time : [Attachment 193412] patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 18 10:02:56 PDT 2013


Antti Koivisto <koivisto at iki.fi> has canceled Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 112457: Determine background visibility at layout time
https://bugs.webkit.org/show_bug.cgi?id=112457

Attachment 193412: patch 2
https://bugs.webkit.org/attachment.cgi?id=193412&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
This is actually somewhat problematic. BitmapImage::frameHasAlphaAtIndex needs
a decoded frame to know if it is transparent but we don't want to decode during
layout (as it may never get painted). This is made less clear-cut but the fact
that frameHasAlphaAtIndex() does not actually care about frames as the current
implementation just checks if the image is jpg or something else.


More information about the webkit-reviews mailing list