[webkit-reviews] review canceled: [Bug 112584] Web Inspector: move _timelineGrid && _timelineOverviewWindow from TimelineOverviewPane into a new class OverviewGrid : [Attachment 193581] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has canceled Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 112584: Web Inspector: move _timelineGrid && _timelineOverviewWindow from
TimelineOverviewPane into a new class OverviewGrid
https://bugs.webkit.org/show_bug.cgi?id=112584

Attachment 193581: Patch
https://bugs.webkit.org/attachment.cgi?id=193581&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193581&action=review


> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:81
> +    this._overviewGrid.grid.element.insertBefore(this._heapGraph.element,
this._overviewGrid.grid.itemsGraphsElement);

You should expose insertBefore on overview grid for now.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:120
> +    get grid()

Don't use getters please.

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:140
> +    updateDividers: function(calculator)

Annotate please.