[webkit-reviews] review denied: [Bug 105135] [Qt/Win] Flash opened in windowed mode when 'wmode' attribute set to 'default' explicitly : [Attachment 179666] Force flash to windowless mode

[bugzilla-daemon at webkit.org]

Allan Sandfeld Jensen <allan.jensen at digia.com> has denied Mozhaev Grigory
<zcrendel at gmail.com>'s request for review:
Bug 105135: [Qt/Win] Flash opened in windowed mode when 'wmode' attribute set
to 'default' explicitly
https://bugs.webkit.org/show_bug.cgi?id=105135

Attachment 179666: Force flash to windowless mode
https://bugs.webkit.org/attachment.cgi?id=179666&action=review

------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179666&action=review


I am not sure about the behaviour change yet, but as a minimum it needs to be
identical in WebKit2 in WebFrameLoaderClient.cpp

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1537
> +	       if ((equalIgnoringCase(values[wmodeIndex], "window")) ||
(equalIgnoringCase(values[wmodeIndex], "default")))

Wrong indentation.