[webkit-reviews] review granted: [Bug 112317] Need to use const String in HTMLVideoElement::posterImageURL : [Attachment 193055] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted michaelbai at chromium.org's
request for review:
Bug 112317: Need to use const String in HTMLVideoElement::posterImageURL
https://bugs.webkit.org/show_bug.cgi?id=112317

Attachment 193055: Patch
https://bugs.webkit.org/attachment.cgi?id=193055&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193055&action=review


r=me with correction below.

> Source/WebCore/ChangeLog:11
> +	   Need to use const String instead of const AtomicString& which means
we will do an extra hash lookup

We don't normally use const with local variables, so not "const String".

> Source/WebCore/html/HTMLVideoElement.cpp:320
> +    const String url = stripLeadingAndTrailingHTMLSpaces(imageSourceURL());

Should be "String", not "const String"