[webkit-reviews] review denied: [Bug 91611] [GStreamer] Stopping playback of html5 media when receiving a higher priority audio event needs implementation : [Attachment 193140] Patch

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 91611: [GStreamer] Stopping playback of html5 media when receiving a higher
priority audio event needs implementation
https://bugs.webkit.org/show_bug.cgi?id=91611

Attachment 193140: Patch
https://bugs.webkit.org/attachment.cgi?id=193140&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=193140&action=review


> Source/WebCore/platform/graphics/MediaPlayer.cpp:1147
> +#if ENABLE(VIDEO) && USE(GSTREAMER)

Not needed.

> Source/WebCore/platform/graphics/MediaPlayer.h:465
> +#if ENABLE(VIDEO) && USE(GSTREAMER)

Ditto

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:191
> +#if ENABLE(VIDEO) && USE(GSTREAMER)

Ditto

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1601

> +#if ENABLE(VIDEO)

This is not needed.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:93
> +#if ENABLE(VIDEO)

Ditto

> Source/WebCore/testing/Internals.cpp:54
> +#if ENABLE(VIDEO) && USE(GSTREAMER)

only ENABLE(VIDEO) is needed.