[webkit-reviews] review denied: [Bug 112321] Web Inspector: [Network] Sort columns context menu items alphabetically. : [Attachment 193068] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 13 23:34:25 PDT 2013
Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 112321: Web Inspector: [Network] Sort columns context menu items
alphabetically.
https://bugs.webkit.org/show_bug.cgi?id=112321
Attachment 193068: Patch
https://bugs.webkit.org/attachment.cgi?id=193068&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193068&action=review
> Source/WebCore/inspector/front-end/NetworkPanel.js:996
> + var title1 = columns[id1].name || columns[id1].title || "";
You should sort by title, not name.
More information about the webkit-reviews
mailing list