[webkit-reviews] review denied: [Bug 105528] [Timeline]Add WebSocket SendFrame, ReceiveFrame and Error message. : [Attachment 193066] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 13 23:32:31 PDT 2013


Pavel Feldman <pfeldman at chromium.org> has denied pdeng6 <pan.deng at intel.com>'s
request for review:
Bug 105528: [Timeline]Add WebSocket SendFrame, ReceiveFrame and Error message.
https://bugs.webkit.org/show_bug.cgi?id=105528

Attachment 193066: Patch
https://bugs.webkit.org/attachment.cgi?id=193066&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Inspector already contains too many features, they all increase its footprint
and complexity, add to maintenance cost and startime time. We can not afford
adding random features into it. Only features that are important / have high
demand in the field / success story in competing products should get in. I have
never seen a request for better websocket inspection in timeline. Given that
websockets are rarely used and even less often they are analysed in performance
perspective, I tend to think that we should remove websocket support from
timeline altogether instead. We already think of removing "glueing" feature
from timeline due to its n^2 complexity and lack of scaling.


More information about the webkit-reviews mailing list