[webkit-reviews] review granted: [Bug 98395] Implement FontLoader interface : [Attachment 192681] Updated patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Kunihiko Sakamoto
<ksakamoto at chromium.org>'s request for review:
Bug 98395: Implement FontLoader interface
https://bugs.webkit.org/show_bug.cgi?id=98395

Attachment 192681: Updated patch
https://bugs.webkit.org/attachment.cgi?id=192681&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=192681&action=review


Thank you for all your hard work on this.

> Source/WebCore/css/CSSFontFace.cpp:140
> +    if (RuntimeEnabledFeatures::fontLoadEventsEnabled() && m_loadState ==
Loading) {

You could have saved yourself a bit of typing by putting these
runtimeenabledfeatures checks into the notify* methods.  But this is fine too.